Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to parse MySQL DATA DIRECTORY argument of DDL #1374

Open
altmannmarcelo opened this issue Sep 20, 2024 · 0 comments
Open

Fail to parse MySQL DATA DIRECTORY argument of DDL #1374

altmannmarcelo opened this issue Sep 20, 2024 · 0 comments
Assignees
Labels
Customer Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync
Milestone

Comments

@altmannmarcelo
Copy link
Contributor

Description

Readyset fails to parse create table if DATA DIRECTORY is set:

# Start MySQL with --innodb_directories=/Users/marcelo/Work/mysql/ins/datadir2/
mysql> create table tb(id int) data directory = '/Users/marcelo/Work/mysql/ins/datadir2/';

Snapshot / Replication fails with:

2024-09-20T19:07:24.096682Z  WARN taking database snapshot: replicators::mysql_connector::snapshot: Error extending CREATE TABLE "db2"."tb3", table will not be used error=Query failed to parse: DATA DIRECTORY='/Users/marcelo/Work/mysql/ins/datadir2/'

Change in user-visible behavior

Requires documentation change

@altmannmarcelo altmannmarcelo added High priority Created by Linear-GitHub Sync Customer Created by Linear-GitHub Sync labels Sep 20, 2024
@altmannmarcelo altmannmarcelo added this to the v.43 milestone Sep 20, 2024
@altmannmarcelo altmannmarcelo self-assigned this Sep 20, 2024
readysetbot pushed a commit that referenced this issue Sep 20, 2024
This commit adds support for parsing the DATA DIRECTORY option from
the CREATE TABLE statement in MySQL.

Ref: REA-4804
Closes: #1374

Release-Note-Core: Add support for parsing the DATA DIRECTORY option
  from the CREATE TABLE statement in MySQL.
Change-Id: I3e2de110027ae6eae5d713644ac8d011e5994f33
@altmannmarcelo altmannmarcelo modified the milestones: v.43, v.44 Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant