-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update paperclip-vips to use kt-paperclip #3
base: master
Are you sure you want to change the base?
Conversation
We have looked at swapping this over but unfortunately we have a lot of other dependencies that rely on the original gem file. Are you using this gem in production @todd-tsu ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will also need to bump the version, probably a major as it changes the main dependency
@@ -7,7 +7,7 @@ A custom paperclip processor that uses the [libvips image processing library](ht | |||
Add this line to your application's Gemfile: | |||
|
|||
```ruby | |||
gem 'paperclip-vips' | |||
gem 'paperclip-vips', :git=>'https://github.com/tsu-social/paperclip-vips.git' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't need this if merging
With paperclip deprecated, we quickly moved to kt-paperclip. I'm happy to create a new gem entirely for this that can pull from any changes if you think that's a better way to go, like kt-paperclip-vips.
Not yet. We are evaluating it for production use though. If we end up not using it, I wouldn't be the right choice to maintain any upstream changes though. |
@todd-tsu I think it makes sense to fork this and run with If you are still evaluating image libraries I highly recommend giving shrine a go - it is great and we are using it in our new projects. It is super customizable and has vips support out of the box. |
With the main paperclip branch being deprecated and unsupported, I think it would be beneficial to have paperclip-vips migrate to using the supported branch, kt-paperclip.