Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix only rule config issues #5725

Conversation

mildm8nnered
Copy link
Collaborator

@mildm8nnered mildm8nnered commented Aug 3, 2024

WIP

Partly addresses #5711

func merged(with child: RulesWrapper) -> RulesWrapper is a problem, as this will not respect --only-rules - we may need a dedicated onlyRule RulesMode to get this to work in all cases.

@mildm8nnered mildm8nnered changed the title Mildm8nnered fix only rule config issues Fix only rule config issues Aug 3, 2024
@SwiftLintBot
Copy link

SwiftLintBot commented Aug 3, 2024

1 Warning
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
17 Messages
📖 Linting Aerial with this PR took 0.93s vs 0.92s on main (1% slower)
📖 Linting Alamofire with this PR took 1.27s vs 1.28s on main (0% faster)
📖 Linting Brave with this PR took 7.42s vs 7.42s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 4.79s vs 4.82s on main (0% faster)
📖 Linting Firefox with this PR took 10.95s vs 10.92s on main (0% slower)
📖 Linting Kickstarter with this PR took 9.91s vs 9.94s on main (0% faster)
📖 Linting Moya with this PR took 0.53s vs 0.53s on main (0% slower)
📖 Linting NetNewsWire with this PR took 2.54s vs 2.54s on main (0% slower)
📖 Linting Nimble with this PR took 0.76s vs 0.77s on main (1% faster)
📖 Linting PocketCasts with this PR took 8.62s vs 8.54s on main (0% slower)
📖 Linting Quick with this PR took 0.44s vs 0.44s on main (0% slower)
📖 Linting Realm with this PR took 4.66s vs 4.64s on main (0% slower)
📖 Linting Sourcery with this PR took 2.35s vs 2.35s on main (0% slower)
📖 Linting Swift with this PR took 4.55s vs 4.56s on main (0% faster)
📖 Linting VLC with this PR took 1.26s vs 1.26s on main (0% slower)
📖 Linting Wire with this PR took 18.04s vs 18.06s on main (0% faster)
📖 Linting WordPress with this PR took 11.75s vs 11.74s on main (0% slower)

Here's an example of your CHANGELOG entry:

* Fix only rule config issues.  
  [mildm8nnered](https://github.com/mildm8nnered)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@mildm8nnered mildm8nnered force-pushed the mildm8nnered-fix-only-rule-config-issues branch 2 times, most recently from 8cf2e0e to de4037c Compare August 9, 2024 21:39
@mildm8nnered mildm8nnered force-pushed the mildm8nnered-fix-only-rule-config-issues branch 5 times, most recently from ba1cc74 to 1f75142 Compare August 25, 2024 12:25
@mildm8nnered mildm8nnered force-pushed the mildm8nnered-fix-only-rule-config-issues branch from 1f75142 to fe91ca2 Compare August 31, 2024 13:04
@mildm8nnered
Copy link
Collaborator Author

Replaced by #5773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants