Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't shrink_to_fit on large changesets #5617

Closed
wants to merge 1 commit into from
Closed

don't shrink_to_fit on large changesets #5617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/realm/sync/changeset_encoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,10 @@ void ChangesetEncoder::append_bytes(const void* bytes, size_t size)
{
// FIXME: It would be better to move ownership of `m_buffer` to the caller,
// potentially reducing the number of allocations to zero (amortized).
m_buffer.reserve(1024); // lower the amount of reallocations
constexpr size_t min_buffer_capacity = 1024;
if (m_buffer.capacity() < min_buffer_capacity) {
m_buffer.reserve(min_buffer_capacity); // lower the amount of reallocations
}
m_buffer.append(static_cast<const char*>(bytes), size);
}

Expand Down