Check if there are any new versions before refreshing in SubscriptionSet #5695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
force-pushed
the
tg/subscription-refresh
branch
2 times, most recently
from
a3ef45e
to
c1e601f
Compare
jbreams
approved these changes
Aug 3, 2022
tgoyne
force-pushed
the
tg/subscription-refresh
branch
from
c1e601f
to
0f87b16
Compare
tgoyne
force-pushed
the
tg/subscription-refresh
branch
from
0f87b16
to
e23028d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty minor but there's some scenarios where we end up calling
refresh()on a SubscriptionSet that definitely hasn't changed a bunch of times and it does a nontrivial amount of work even if there's no newer transaction versions.#5150 added a second call to
get_by_version(version())and I don't see how the first call could possibly have any effect, so I removed it.