PR feedback 2

realm · May 29, 2024 · 149fe39 · 149fe39
1 parent 010d57d
commit 149fe39
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/.github/workflows/dart-desktop-tests.yml b/.github/workflows/dart-desktop-tests.yml
@@ -38,16 +38,17 @@ jobs:
         run: false # fail if arch is not as expected
         shell: bash
 
-      - name: Set RUNNER_OS
+      - id: runner_os_lowercase
         # there is no such thing as ${{ tolower(runner.os) }}, hence this abomination ¯\_(ツ)_/¯ 
-        run: echo ${{ runner.os }} | awk '{print "RUNNER_OS=" tolower($0)}' >> $GITHUB_ENV
+        # use with steps.runner_os_lowercase.outputs.os
+        run: echo ${{ runner.os }} | awk '{print "os=" tolower($0)}' >> $GITHUB_OUTPUT
         shell: bash
 
       - name: Fetch artifacts
         uses: actions/download-artifact@v4
         with:
-          name: librealm-${{ env.RUNNER_OS }}
-          path: packages/realm_dart/binary/${{ env.RUNNER_OS }}
+          name: librealm-${{ steps.runner_os_lowercase.outputs.os }}
+          path: packages/realm_dart/binary/${{ steps.runner_os_lowercase.outputs.os }}
 
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@main

diff --git a/.github/workflows/flutter-desktop-tests.yml b/.github/workflows/flutter-desktop-tests.yml
@@ -43,9 +43,10 @@ jobs:
         run: false # fail if arch is not as expected
         shell: bash
 
-      - name: Set RUNNER_OS
+      - id: runner_os_lowercase
         # there is no such thing as ${{ tolower(runner.os) }}, hence this abomination ¯\_(ツ)_/¯ 
-        run: echo ${{ runner.os }} | awk '{print "RUNNER_OS=" tolower($0)}' >> $GITHUB_ENV
+        # use with steps.runner_os_lowercase.outputs.os
+        run: echo ${{ runner.os }} | awk '{print "os=" tolower($0)}' >> $GITHUB_OUTPUT
         shell: bash
 
       - name: Setup GTK & Ninja on Linux
@@ -57,8 +58,8 @@ jobs:
       - name: Fetch artifacts
         uses: actions/download-artifact@v4
         with:
-          name: librealm-${{ env.RUNNER_OS }}
-          path: packages/realm_dart/binary/${{ env.RUNNER_OS }}
+          name: librealm-${{ steps.runner_os_lowercase.outputs.os }}
+          path: packages/realm_dart/binary/${{ steps.runner_os_lowercase.outputs.os }}
 
       - name: Setup Flutter
         uses: subosito/flutter-action@v2
@@ -86,7 +87,7 @@ jobs:
           flutter test integration_test/all_tests.dart \
             --dart-define=BAAS_BAASAAS_API_KEY=$BAAS_BAASAAS_API_KEY \
             --dart-define=BAAS_DIFFERENTIATOR=$BAAS_DIFFERENTIATOR \
-            --device-id=${{ env.RUNNER_OS }} \
+            --device-id=${{ steps.runner_os_lowercase.outputs.os }} \
             --file-reporter=json:test-results.json \
             --suppress-analytics
         shell: bash