asymmetric object allow non embedded links (#1402)

Co-authored-by: Nikola Irinchev <[email protected]>

CHANGELOG.md

@@ -10,6 +10,7 @@
    * `SyncClientError`, `SyncConnectionError`, `SyncSessionError`, `SyncWebSocketError`, `GeneralSyncError` - replaced by `SyncError`.
    * `SyncClientErrorCode`, `SyncConnectionErrorCode`, `SyncSessionErrorCode`, `SyncWebSocketErrorCode`, `GeneralSyncErrorCode, SyncErrorCategory` - replaced by `SyncErrorCode`.
 * Throw an exception if `File::unlock` has failed, in order to inform the SDK that we are likely hitting some limitation on the OS filesystem, instead of crashing  the application and use the same file locking logic for all the platforms. (Core upgrade)
+* Lift a restriction that prevents asymmetric objects from linking to non-embedded objects. ([#1403](https://github.com/realm/realm-dart/issues/1403))
 
 ### Fixed
 * Fixed iteration after `skip` bug ([#1409](https://github.com/realm/realm-dart/issues/1409))
@@ -31,7 +32,7 @@
 * Sync protocol version bumped to 10. (Core upgrade)
 * Handle `badChangeset` error when printing changeset contents in debug. (Core upgrade)
 
-* Using Core 13.20.1.
+* Using Core 13.23.2.
 
 ## 1.5.0 (2023-09-18)
 

generator/lib/src/class_element_ex.dart

@@ -188,17 +188,11 @@ extension ClassElementEx on ClassElement {
         }
       }
 
-      // Check that asymmetric objects:
-      // 1) only have links to embedded objects.
-      // 2) have a primary key named _id.
+      // Check that asymmetric objects have a primary key named _id.
       if (objectType == ObjectType.asymmetricObject) {
         var hasPrimaryKey = false;
         for (final field in mappedFields) {
           final fieldElement = field.fieldElement;
-          final classElement = fieldElement.type.basicType.element as ClassElement;
-          if (field.type.basicType.isRealmModel && !classElement.thisType.isRealmModelOfType(ObjectType.embeddedObject)) {
-            throw RealmInvalidGenerationSourceError('Asymmetric objects cannot link to non-embedded objects', todo: '', element: fieldElement);
-          }
           if (field.isPrimaryKey) {
             hasPrimaryKey = true;
             if (field.realmName != '_id') {

test/asymmetric_test.dart

@@ -59,7 +59,7 @@ Future<void> main([List<String>? args]) async {
     await realm.syncSession.waitForUpload();
   });
 
-  baasTest('Asymmetric tricks to add non-embedded links', (config) async {
+  baasTest('Asymmetric add non-embedded links', (config) async {
     final realm = await getIntegrationRealm(appConfig: config);
 
     realm.subscriptions.update((mutableSubscriptions) {
@@ -68,8 +68,7 @@ Future<void> main([List<String>? args]) async {
 
     realm.write(() {
       final s = realm.add(Symmetric(ObjectId()));
-      // Since this shenanigan is allowed, I have opened a feature request to allow
-      // direct links on a symmetric objects. See https://github.com/realm/realm-core/issues/6976.
+      realm.ingest(Asymmetric(ObjectId(), symmetric: s));
       realm.ingest(Asymmetric(ObjectId(), embeddedObjects: [Embedded(1, symmetric: s)]));
       realm.ingest(Asymmetric(ObjectId(), embeddedObjects: [Embedded(1, any: RealmValue.from(s))]));
     });

test/test.dart

@@ -333,6 +333,7 @@ class _Asymmetric {
   @MapTo('_id')
   late ObjectId id;
 
+  _Symmetric? symmetric;
   late List<_Embedded> embeddedObjects;
 }