Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Dart 2.17 NativeFinalizer classes #582

Closed
sync-by-unito bot opened this issue May 17, 2022 · 0 comments · Fixed by #754
Closed

Use Dart 2.17 NativeFinalizer classes #582

sync-by-unito bot opened this issue May 17, 2022 · 0 comments · Fixed by #754
Assignees
@nielsenko

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 17, 2022 •
edited
Loading

No description provided.

nielsenko added a commit that referenced this issue Aug 15, 2022
@nielsenko
Classes with Finalizable fields implements Finalizable
5938b56 
Classes that implements Finalizable:
* App,
* FlexibleSyncConfiguration,
* HandleBase,
* Realm,
* RealmEntity,
* RealmList,
* RealmResults,
* Subscription,
* SubscriptionSet, and
* User,

The corresponding XInternal extension classes implements a keepAlive
function to ensure finalizable fields always live as long as their
finalizable parent. This is workaround for:
dart-lang/sdk#49643

Resolves: #581, resolves: #582
@sync-by-unito sync-by-unito bot changed the title Use Dart 2.17 NativeFinalizer classes Use Dart 2.17 NativeFinalizer classes Aug 15, 2022
nielsenko added a commit that referenced this issue Aug 15, 2022
@nielsenko
Classes with Finalizable fields implements Finalizable
1fd7dfc 
Classes that implements Finalizable:
* App,
* FlexibleSyncConfiguration,
* HandleBase,
* Realm,
* RealmEntity,
* RealmList,
* RealmResults,
* Subscription,
* SubscriptionSet, and
* User,

The corresponding XInternal extension classes implements a keepAlive
function to ensure finalizable fields always live as long as their
finalizable parent. This is workaround for:
dart-lang/sdk#49643

Resolves: #581, resolves: #582
nielsenko added a commit that referenced this issue Aug 16, 2022
@nielsenko
Classes with Finalizable fields implements Finalizable
684e64f 
Classes that implements Finalizable:
* App,
* FlexibleSyncConfiguration,
* HandleBase,
* Realm,
* RealmEntity,
* RealmList,
* RealmResults,
* Subscription,
* SubscriptionSet, and
* User,

The corresponding XInternal extension classes implements a keepAlive
function to ensure finalizable fields always live as long as their
finalizable parent. This is workaround for:
dart-lang/sdk#49643

Resolves: #581, resolves: #582
nielsenko added a commit that referenced this issue Aug 16, 2022
@nielsenko
Classes with Finalizable fields implements Finalizable
cea2950 
Classes that implements Finalizable:
* App,
* FlexibleSyncConfiguration,
* HandleBase,
* Realm,
* RealmEntity,
* RealmList,
* RealmResults,
* Subscription,
* SubscriptionSet, and
* User,

The corresponding XInternal extension classes implements a keepAlive
function to ensure finalizable fields always live as long as their
finalizable parent. This is workaround for:
dart-lang/sdk#49643

Resolves: #581, resolves: #582
@nielsenko nielsenko mentioned this issue Aug 16, 2022
Merged
nielsenko added a commit that referenced this issue Aug 16, 2022
@nielsenko
Use Finalizable to ensure lexical liveness (#754)
92d151e 
* HandleBase implements Finalizable, and uses a common NativeFinalizer

* Classes with Finalizable fields implements Finalizable

Classes that implements Finalizable:
* App,
* FlexibleSyncConfiguration,
* HandleBase,
* Realm,
* RealmEntity,
* RealmList,
* RealmResults,
* Subscription,
* SubscriptionSet, and
* User,

The corresponding XInternal extension classes implements a keepAlive
function to ensure finalizable fields always live as long as their
finalizable parent. This is workaround for:
dart-lang/sdk#49643

Resolves: #581, resolves: #582

* Remove redundant code

* Implement Finalizable on more classes
* RealmObject,
* RealmObjectChanges, and
* RealmCollectionChanges.

Drop from RealmEntity

* Implements Finalizable on SyncSession

* Don't use `assert(() { ...; return true; }());` trick for finalization trace. Instead have const flag and depend on tree-shaking

* Update CHANGELOG
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nielsenko nielsenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Finalizable to ensure lexical liveness realm/realm-dart
1 participant
@nielsenko