Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyncSessionErrorCode.compensatingWrite(231) #1022

Merged
merged 6 commits into from
Nov 15, 2022
Merged

SyncSessionErrorCode.compensatingWrite(231) #1022

merged 6 commits into from
Nov 15, 2022

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Nov 10, 2022 •
edited
Loading

@cla-bot cla-bot bot added the cla: yes label Nov 10, 2022
@coveralls
Copy link

coveralls commented Nov 10, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3470250968

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 88.972%
Totals Coverage Status
Change from base Build 3469463055: 0.06%
Covered Lines: 2751
Relevant Lines: 3092
💛 - Coveralls

@desistefanova desistefanova requested review from blagoev, nirinchev and nielsenko and removed request for nirinchev November 11, 2022 07:44
@desistefanova desistefanova marked this pull request as ready for review November 11, 2022 07:44
@desistefanova desistefanova changed the title syncErrorHandler - provide better details SyncSessionErrorCode.compensatingWrite(231) Nov 11, 2022
nirinchev
nirinchev approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we write a test for this? I don't see a reason why it wouldn't work, but it would be nice to have a test that verifies it.

@desistefanova
Copy link
Contributor Author

Can we write a test for this? I don't see a reason why it wouldn't work, but it would be nice to have a test that verifies it.

I added one test.

@desistefanova desistefanova merged commit 7f4331e into master Nov 15, 2022
@desistefanova desistefanova deleted the sync_error_mapping branch November 15, 2022 12:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsenko nielsenko nielsenko approved these changes

@blagoev blagoev blagoev approved these changes

@nirinchev nirinchev nirinchev approved these changes

Assignees

@desistefanova desistefanova

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: syncErrorHandler doesn't occur because of mapping error codes exception
5 participants
@desistefanova @coveralls @nirinchev @blagoev @nielsenko