Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max number of active versions #1036

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Max number of active versions #1036

merged 4 commits into from
Nov 15, 2022

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Nov 14, 2022 •
edited
Loading

Config: Support max number of active versions allowed property.
Fixes #87

@cla-bot cla-bot bot added the cla: yes label Nov 14, 2022
@coveralls
Copy link

coveralls commented Nov 14, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3468502462

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 88.907%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/native/realm_core.dart 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
lib/src/native/realm_core.dart 1 90.04%
Totals Coverage Status
Change from base Build 3465165734: 0.007%
Covered Lines: 2749
Relevant Lines: 3092
💛 - Coveralls

@desistefanova desistefanova marked this pull request as ready for review November 14, 2022 22:30
nielsenko
nielsenko approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better with the freeze based test 👍

@desistefanova desistefanova merged commit 82b28f8 into master Nov 15, 2022
@desistefanova desistefanova deleted the max_active_versions branch November 15, 2022 10:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsenko nielsenko nielsenko approved these changes

@blagoev blagoev blagoev approved these changes

@nirinchev nirinchev nirinchev approved these changes

Assignees

@desistefanova desistefanova

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config: Support max active versions allowed property
5 participants
@desistefanova @coveralls @nirinchev @blagoev @nielsenko