Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use random tmp destination for download #1061

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Use random tmp destination for download #1061

merged 2 commits into from
Dec 14, 2022

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Dec 14, 2022 •
edited
Loading

This avoid conflict between users on the same machine.

Fixes #1060

@cla-bot cla-bot bot added the cla: yes label Dec 14, 2022
@nielsenko nielsenko mentioned this pull request Dec 14, 2022
Closed
blagoev
blagoev approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a changelog entry

@coveralls
Copy link

coveralls commented Dec 14, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3693852171

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 89.024%
Files with Coverage Reduction New Missed Lines %
lib/src/subscription.dart 1 90.48%
Totals Coverage Status
Change from base Build 3693832369: -0.03%
Covered Lines: 2774
Relevant Lines: 3116
💛 - Coveralls

@nielsenko nielsenko marked this pull request as ready for review December 14, 2022 10:04
@nielsenko nielsenko force-pushed the kn/fix-install-tmp-destination branch from c0a63e4 to 8fa07f6 Compare December 14, 2022 10:12
@nielsenko
Use random tmp destination for download
8b6d414 
This avoid conflict between users on the same machine.
@nielsenko
Update CHANGELOG
9e82306
@nielsenko nielsenko force-pushed the kn/fix-install-tmp-destination branch from 8fa07f6 to 9e82306 Compare December 14, 2022 10:19
@nielsenko nielsenko merged commit 4bba93a into main Dec 14, 2022
@nielsenko nielsenko deleted the kn/fix-install-tmp-destination branch December 14, 2022 10:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blagoev blagoev blagoev approved these changes

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: can't install realm binary
3 participants
@nielsenko @coveralls @blagoev