Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientResetError.resetRealm #1067

Closed
wants to merge 3 commits into from
Closed

ClientResetError.resetRealm #1067

wants to merge 3 commits into from

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Dec 17, 2022 •
edited
Loading

  • Return bool from ClientResetError.resetRealm to indicate if reset was initiated or not
  • Update CHANGELOG

Resolves: #1068

@cla-bot cla-bot bot added the cla: yes label Dec 17, 2022
@nielsenko nielsenko force-pushed the kn/fix-realm-reset branch 2 times, most recently from eb1738d to b6e49e7 Compare December 19, 2022 13:08
@coveralls
Copy link

coveralls commented Dec 19, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3744433744

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 89.252%
Totals Coverage Status
Change from base Build 3741611178: 0.07%
Covered Lines: 2815
Relevant Lines: 3154
💛 - Coveralls

desistefanova
desistefanova reviewed Dec 19, 2022
View reviewed changes
Copy link
Contributor

@desistefanova desistefanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this easy to be tested?

@nielsenko nielsenko changed the base branch from main to kn/update-core January 9, 2023 13:57
@nielsenko nielsenko force-pushed the kn/update-core branch 3 times, most recently from 0cc14d9 to f728142 Compare January 10, 2023 20:01
Base automatically changed from kn/update-core to main January 11, 2023 10:10
@nielsenko
Copy link
Contributor Author

Superceeded by #1093

@nielsenko nielsenko closed this Jan 13, 2023
@nirinchev nirinchev deleted the kn/fix-realm-reset branch November 10, 2023 13:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desistefanova desistefanova desistefanova left review comments

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Surface result from SyncManager::immediately_run_file_actions
3 participants
@nielsenko @coveralls @desistefanova