RDART-914: Use PartBuilder instead of SharedPartBuilder #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsenko
force-pushed
the
kn/part-builder
branch
15 times, most recently
from
7d07c7a
to
4d2e29e
Compare
Pull Request Test Coverage Report for Build 7958047585Details
💛 - Coveralls |
nielsenko
force-pushed
the
kn/part-builder
branch
2 times, most recently
from
e60647f
to
0495de8
Compare
Closed
nielsenko
force-pushed
the
kn/part-builder
branch
from
c24c821
to
be88743
Compare
nielsenko
force-pushed
the
kn/part-builder
branch
from
be88743
to
11cab71
Compare
nielsenko
force-pushed
the
kn/part-builder
branch
2 times, most recently
from
04e767a
to
d0bcb72
Compare
nielsenko
force-pushed
the
kn/part-builder
branch
3 times, most recently
from
6ac22ab
to
7408c20
Compare
nirinchev
approved these changes
Feb 8, 2024
packages/realm_generator/test/error_test_data/invalid_model_name_mapping.dart
Show resolved
Hide resolved
|
Also, this is a breaking change, so we should have probably targeted ni/core-vnext instead of main. |
This will allow other builders to consume output of the realm generator. Generated files are now suffixed with `.realm.dart` instead of `.g.dart`.
Instead of reading it from the console. Github windows actions are weird in this respect. The logs will alway be rendered with unicode anyway.
nielsenko
force-pushed
the
kn/part-builder
branch
from
48950c2
to
45d6c2d
Compare
nielsenko
force-pushed
the
kn/part-builder
branch
from
c531cdd
to
4b440d1
Compare
nielsenko
force-pushed
the
kn/part-builder
branch
from
4b440d1
to
a715940
Compare
nirinchev
added a commit
that referenced
this pull request
Feb 23, 2024
* main: Use PartBuilder instead of SharedPartBuilder (#1310)
nirinchev
added a commit
that referenced
this pull request
Feb 23, 2024
* next-major: Regenerate ffi bindings Fix paths Update Core Move cmake presets back in realm_dart Use PartBuilder instead of SharedPartBuilder (#1310)
nielsenko
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow other builders to consume output of the realm generator.
Generated files are now suffixed with
.realm.dartinstead of.g.dart.Due to the behaviour of
PartBuildersource files needs to have apartdeclaration (SharedPartBuilderis more lenient for some reason). This means that the trick we used in the tests of not specifying the part no longer works. Instead a lot mock files has been added, of the form<x>.realm.dartcontaining:mostly to avoid a lot of red squiggles in the project due to parse errors.
test_utils.darthas been reworked quite a bit in the process, and now contains atestCompilemethod for easy testing of the builder.Related to: #1254