Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

push packages/ into realm/ in prep for ejson/ #1518

Closed
wants to merge 10 commits into from
Closed

push packages/ into realm/ in prep for ejson/ #1518

wants to merge 10 commits into from

Conversation

nielsenko
Copy link
Contributor

No description provided.

@nielsenko
Use PartBuilder instead of SharedPartBuilder
e420a18 
This will allow other builders to consume output of the realm generator.
Generated files are now suffixed with `.realm.dart` instead of `.g.dart`.
@nielsenko
Fix generator tests
ec806b4
@nielsenko
Rude fix
1f124ca
@nielsenko
Force unicode glyphs in error messages
4146d70 
Instead of reading it from the console. Github windows actions are weird
in this respect. The logs will alway be rendered with unicode anyway.
@nielsenko
Fix ordering of async info tests
7a443e4
@nielsenko
Fix multi-file generate
f464189
@nielsenko
Update CHANGELOG
11a5e9e
@nielsenko
Update workflows
a796f05
@nielsenko
Fix generator tests after rebase
7408c20
@nielsenko
push packages/ into realm/ in prep for ejson/
4b06f74
@nielsenko nielsenko self-assigned this Feb 7, 2024
@cla-bot cla-bot bot added the cla: yes label Feb 7, 2024
nirinchev
nirinchev reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some context here - why are we pushing them into realm/packages? What's the target repo structure?

@nielsenko
Copy link
Contributor Author

Need some context here - why are we pushing them into realm/packages? What's the target repo structure?

Do we want a structure like:

realm/
  packages/
     realm/
     realm_common/
     realm_dart/
     realm_generator/
ejson/
  packages/
     ejson/
     ejson_lint/
     ejson_generator/
     ...

or the flatter:

packages/
  realm/
  realm_common/
  realm_dart/
  realm_generator/
  ejson/
  ejson_lint/
  ejson_generator/
     ...

This PR aims for the former, but I can be persuaded either way.

Base automatically changed from kn/part-builder to main February 19, 2024 10:53
@nielsenko
Copy link
Contributor Author

We will go with

packages/
  realm/
  realm_common/
  realm_dart/
  realm_generator/
  ejson/
  ejson_lint/
  ejson_generator/
     ...

Hence, I will close this PR

@nielsenko nielsenko closed this Feb 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev left review comments

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsenko @nirinchev