-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
realm delete many #153
realm delete many #153
Conversation
b212667
to
ca27374
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly questions and nits from me - I was just curious about the PR.
Please link to the issues this resolves with "Fixes #xyz". |
1a7a69e
to
9942fc7
Compare
OK, thanks. Done. |
also we should snapshot before iteration |
Note that snapshotting is only possible for object collections - I don't think dart supports results of primitives yet, but when you do, you won't be able to snapshot those. |
…eMany=>deleteMany
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider name change
Co-authored-by: blagoev <[email protected]>
Co-authored-by: blagoev <[email protected]>
…tDeleteAll ->listDeleteAll
realm.deleteMany implemented "Fixes #60".
Support RealmResults for..in "Fixes #37" without snapshot