Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDART-972: Prepare breaking change for progress notifications #1563

Merged
merged 2 commits into from
Mar 14, 2024
Merged

RDART-972: Prepare breaking change for progress notifications #1563

merged 2 commits into from
Mar 14, 2024

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Mar 14, 2024 •
edited
Loading

Fixes #1562

@cla-bot cla-bot bot added the cla: yes label Mar 14, 2024
nielsenko
nielsenko approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 8286710353

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 86.509%
Totals Coverage Status
Change from base Build 8282638016: 0.006%
Covered Lines: 5739
Relevant Lines: 6634
💛 - Coveralls

@nirinchev nirinchev merged commit 465e3bd into main Mar 14, 2024
55 of 56 checks passed
@nirinchev nirinchev deleted the ni/progress-estimate-prep branch March 14, 2024 20:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsenko nielsenko nielsenko approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace SyncProgress.transferred/transferable with estimate
2 participants
@nirinchev @nielsenko