-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow nullable PKs #459
Allow nullable PKs #459
Conversation
Pull Request Test Coverage Report for Build 2102883118
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to have a discussion about this offline.
I converted to draft. If we close it someone might delete the branch. Let's keep it for a while. I know dangling PRs are not great but... |
We can always restore the branch from the Github UI. And by the time we decide to work on it, the code will likely have rotted enough, that it'd be easier to just use the PR as inspiration and start from scratch. |
Fixes #458