Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nullable PKs #459

Closed
wants to merge 2 commits into from
Closed

Allow nullable PKs #459

wants to merge 2 commits into from

Conversation

nirinchev
Copy link
Member

Fixes #458

@coveralls
Copy link

coveralls commented Apr 6, 2022

Pull Request Test Coverage Report for Build 2102883118

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 91.469%

Files with Coverage Reduction New Missed Lines %
generator/lib/src/utils.dart 1 66.67%
Totals Coverage Status
Change from base Build 2094856042: -0.4%
Covered Lines: 386
Relevant Lines: 422

💛 - Coveralls

@cla-bot cla-bot bot added the cla: yes label Apr 6, 2022
@nirinchev nirinchev self-assigned this Apr 6, 2022
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have a discussion about this offline.

@nirinchev
Copy link
Member Author

@blagoev did you get a chance to get buy-in from @ianpward on not supporting nullable PKs in the dart SDK? If so, I propose we close the PR and we can always reopen if user requests come in.

@blagoev blagoev marked this pull request as draft April 29, 2022 09:41
@blagoev
Copy link
Contributor

blagoev commented Apr 29, 2022

I converted to draft. If we close it someone might delete the branch. Let's keep it for a while. I know dangling PRs are not great but...

@nirinchev
Copy link
Member Author

We can always restore the branch from the Github UI. And by the time we decide to work on it, the code will likely have rotted enough, that it'd be easier to just use the PR as inspiration and start from scratch.

@nirinchev nirinchev mentioned this pull request Aug 17, 2022
@nirinchev nirinchev closed this Aug 17, 2022
@nirinchev nirinchev deleted the ni/nullable-pks branch August 18, 2022 22:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Primary keys should allow to be nullable
4 participants