Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose customData and refreshCustomData on User #525

Merged
merged 15 commits into from
May 4, 2022
Merged

Expose customData and refreshCustomData on User #525

merged 15 commits into from
May 4, 2022

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Apr 30, 2022 •
edited
Loading

Expose app property on User
Expose customData and refreshCustomData on User
switch to VS 2022 for Windows Builds (locally and on CI)

closes #423
closes #410
closes #411
closes #420
closes #417
closes #418
closes #415

@blagoev
Expose app property on User
ec29a44 
Expose customData and refreshCustomData on User
switch to VS 2022 for Windows Builds (locally and on CI)
@cla-bot cla-bot bot added the cla: yes label Apr 30, 2022
@blagoev blagoev changed the title Expose app property on User Expose customData and refreshCustomData on User Apr 30, 2022
@coveralls
Copy link

coveralls commented Apr 30, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2268076037

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.677%
Totals Coverage Status
Change from base Build 2244513339: 0.0%
Covered Lines: 400
Relevant Lines: 427
💛 - Coveralls

@blagoev blagoev self-assigned this May 1, 2022
nirinchev
nirinchev reviewed May 2, 2022
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - mostly minor comments from me.

lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Show resolved Hide resolved
lib/src/native/realm_core.dart Show resolved Hide resolved
lib/src/user.dart Outdated Show resolved Hide resolved
@realm realm deleted a comment from privcmtnsu May 3, 2022
@blagoev blagoev merged commit cd6240b into master May 4, 2022
@blagoev blagoev deleted the blagoev/custom-user-data branch May 4, 2022 11:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev left review comments

@desistefanova desistefanova desistefanova approved these changes

Assignees

@blagoev blagoev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
4 participants
@blagoev @coveralls @nirinchev @desistefanova