Fix boolean #557
Merged
Fix boolean #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2293510920
💛 - Coveralls |
nirinchev
reviewed
May 8, 2022
There was a problem hiding this comment.
The changes seem fine to me, but I don't think the test is actually validating the fix - i.e. I expect the same test to have passed with the previous implementation due to the symmetric nature of the bug. A more robust test can be written using the to_json method on RealmObject and validating that the serialized json value matches expectations.
desistefanova
approved these changes
May 9, 2022
There was a problem hiding this comment.
Agree with @nirinchev about items order could not be the same as the insertion order.
|
Insertion order is pretty much set in stone now. I can show you examples of tests depending on this behavior in every SDK. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes boolean value persistence
fixes #474