Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test external auth providers credentials #745

Merged
merged 24 commits into from
Aug 12, 2022

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Aug 3, 2022

Test login with Facebook credentials.

@cla-bot cla-bot bot added the cla: yes label Aug 3, 2022
@desistefanova desistefanova changed the base branch from master to kn/auth-providers-no-tests August 3, 2022 17:05
@desistefanova desistefanova changed the title Test external auth providers Test external auth providers credentials Aug 3, 2022
@desistefanova desistefanova self-assigned this Aug 3, 2022
Base automatically changed from kn/auth-providers-no-tests to master August 5, 2022 13:26
@desistefanova desistefanova marked this pull request as ready for review August 9, 2022 19:02
@desistefanova desistefanova requested review from blagoev, nirinchev and nielsenko and removed request for blagoev and nirinchev August 9, 2022 19:02
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/credentials_test.dart Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion on the readme file changes. I suggest we do it a bit before merging.

test/README.md Outdated Show resolved Hide resolved
@desistefanova desistefanova merged commit f248a3c into master Aug 12, 2022
@desistefanova desistefanova deleted the ds/test_external_auth_providers branch August 12, 2022 14:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants