Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update realm-core to v12.5.0 #750

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Update realm-core to v12.5.0 #750

merged 3 commits into from
Aug 12, 2022

Conversation

nielsenko
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla: yes label Aug 10, 2022
@nielsenko nielsenko self-assigned this Aug 10, 2022
@nielsenko nielsenko force-pushed the kn/update-core branch 2 times, most recently from 364c3ae to fe5020c Compare August 11, 2022 06:28
blagoev
blagoev reviewed Aug 11, 2022
View reviewed changes
lib/src/credentials.dart Outdated Show resolved Hide resolved
blagoev
blagoev approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a little suggestion on the API doc for the enum

desistefanova
desistefanova reviewed Aug 11, 2022
View reviewed changes
Copy link
Contributor

@desistefanova desistefanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a test with anonymousNoReuse option.

@nielsenko
Copy link
Contributor Author

It would be nice to have a test with anonymousNoReuse option.

I have added the test-case: Anonymous - new user to credentials_test.dart

@nielsenko
Copy link
Contributor Author

I have a little suggestion on the API doc for the enum

👍

@nielsenko nielsenko merged commit 82db10e into master Aug 12, 2022
@nielsenko nielsenko deleted the kn/update-core branch August 12, 2022 12:36
@nielsenko nielsenko linked an issue Aug 12, 2022 that may be closed by this pull request
Upgrade realm-core to v12.5.0 #752
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desistefanova desistefanova desistefanova approved these changes

@blagoev blagoev blagoev approved these changes

@nirinchev nirinchev Awaiting requested review from nirinchev

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade realm-core to v12.5.0
3 participants
@nielsenko @blagoev @desistefanova