Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add realm specific implementation for List.add and List.insert #894

Merged
merged 4 commits into from
Sep 12, 2022

Conversation

nielsenko
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3023652286

  • -1 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.7%) to 92.891%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/list.dart 6 7 85.71%
Totals Coverage Status
Change from base Build 3013691132: 5.7%
Covered Lines: 392
Relevant Lines: 422

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 9, 2022

Pull Request Test Coverage Report for Build 3036265550

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.2%) to 86.001%

Totals Coverage Status
Change from base Build 3013691132: -1.2%
Covered Lines: 1671
Relevant Lines: 1943

💛 - Coveralls

@nielsenko nielsenko self-assigned this Sep 11, 2022
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a test for the removeRange path of length setter

test/list_test.dart Outdated Show resolved Hide resolved
@nielsenko
Copy link
Contributor Author

I think we should add a test for the removeRange path of length setter

I have added the requested test

@nielsenko nielsenko merged commit d1d4857 into master Sep 12, 2022
@nielsenko nielsenko deleted the kn/implement-list-add-and-insert branch September 12, 2022 10:41
@@ -63,7 +63,11 @@ class ManagedRealmList<T extends Object?> extends collection.ListBase<T> with Re
@override
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@override
/// Setting the `length` is a required method on [List], but makes less sense
/// for [RealmList]s. You can only decrease the length, increasing it throws an [RealmException].

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants