Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an action to enforce changelog #944

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Add an action to enforce changelog #944

merged 3 commits into from
Oct 10, 2022

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Oct 5, 2022 •
edited
Loading

Fixes #939

Example failure: https://github.com/realm/realm-dart/actions/runs/3192287922/jobs/5209591627

To disable the check, add no-changelog label.

@cla-bot cla-bot bot added the cla: yes label Oct 5, 2022
@nirinchev nirinchev added no-changelog Used to skip the changelog check and removed no-changelog Used to skip the changelog check labels Oct 5, 2022
@nirinchev nirinchev marked this pull request as ready for review October 5, 2022 20:01
@nirinchev nirinchev self-assigned this Oct 5, 2022
nielsenko
nielsenko approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

desistefanova
desistefanova reviewed Oct 5, 2022
View reviewed changes
Copy link
Contributor

@desistefanova desistefanova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. I wonder why the the others build action are not run.

Oh, I saw that you have canceled them.

@blagoev blagoev added no-changelog Used to skip the changelog check and removed no-changelog Used to skip the changelog check labels Oct 10, 2022
@nirinchev nirinchev merged commit c47fe49 into master Oct 10, 2022
@nirinchev nirinchev deleted the ni/changelog-enforcer branch October 10, 2022 10:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desistefanova desistefanova desistefanova approved these changes

@nielsenko nielsenko nielsenko approved these changes

@blagoev blagoev blagoev approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a github action workflow to remind about changelog entry
4 participants
@nirinchev @blagoev @nielsenko @desistefanova