Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atlas functions support #973

Merged
merged 21 commits into from
Oct 25, 2022
Merged

Atlas functions support #973

merged 21 commits into from
Oct 25, 2022

Conversation

desistefanova
Copy link
Contributor

Implements FunctionsClient with method call that gives a possibility to call Atlas App Function from Realm Dart SDK with a logged in user and to get its result.
Fixes: #812

@cla-bot cla-bot bot added the cla: yes label Oct 18, 2022
@blagoev blagoev changed the title Call Atlas function Atlas functions support Oct 18, 2022
@desistefanova desistefanova marked this pull request as ready for review October 19, 2022 07:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3281195557

  • 0 of 27 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 87.967%
Totals Coverage Status
Change from base Build 3273943496: -0.6%
Covered Lines: 2120
Relevant Lines: 2410
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 19, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3319315066

  • 27 of 27 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 88.195%
Totals Coverage Status
Change from base Build 3319274302: -0.6%
Covered Lines: 2174
Relevant Lines: 2465
💛 - Coveralls

@nirinchev
Minor tweaks to the call function API
03f9115 
(cherry picked from commit b9b0a4e)
blagoev
blagoev suggested changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api doc seems off

CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/native/realm_core.dart Outdated Show resolved Hide resolved
lib/src/user.dart Outdated Show resolved Hide resolved
test/test.dart Outdated Show resolved Hide resolved
nirinchev
nirinchev approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/app_test.dart Show resolved Hide resolved
@desistefanova @nirinchev
Update test/app_test.dart
7c7b873 
Co-authored-by: Nikola Irinchev <[email protected]>
blagoev
blagoev suggested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets init FunctionsClient lazily

lib/src/user.dart Show resolved Hide resolved
lib/src/user.dart Show resolved Hide resolved
desistefanova
desistefanova commented Oct 24, 2022
View reviewed changes
lib/src/user.dart Outdated Show resolved Hide resolved
blagoev
blagoev approved these changes Oct 25, 2022
View reviewed changes
lib/src/user.dart Outdated Show resolved Hide resolved
lib/src/user.dart Outdated Show resolved Hide resolved
@blagoev
Apply suggestions from code review
adc63cc 
revert suggested lazy init
nielsenko
nielsenko reviewed Oct 25, 2022
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions regarding support for cancellation

lib/src/user.dart Show resolved Hide resolved
lib/src/native/realm_core.dart Show resolved Hide resolved
@desistefanova desistefanova merged commit 1a94102 into master Oct 25, 2022
@desistefanova desistefanova deleted the ds/call_user_function branch October 25, 2022 12:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blagoev blagoev blagoev approved these changes

@nirinchev nirinchev nirinchev approved these changes

@nielsenko nielsenko nielsenko approved these changes

Assignees

@desistefanova desistefanova

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling Atlas App Services Functions
5 participants
@desistefanova @coveralls @nirinchev @blagoev @nielsenko