Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve robustness of API key tests #978

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Improve robustness of API key tests #978

merged 2 commits into from
Oct 21, 2022

Conversation

nirinchev
Copy link
Member

I don't think we have an issue for this, but took a stab at adding some retry logic to our API key tests.

@cla-bot cla-bot bot added the cla: yes label Oct 20, 2022
@nirinchev nirinchev added the no-changelog Used to skip the changelog check label Oct 20, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3292306742

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 87.998%
Totals Coverage Status
Change from base Build 3273943496: -0.5%
Covered Lines: 2097
Relevant Lines: 2383
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3292306742

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 87.998%
Totals Coverage Status
Change from base Build 3273943496: -0.5%
Covered Lines: 2097
Relevant Lines: 2383
💛 - Coveralls

@nirinchev nirinchev merged commit 7976865 into master Oct 21, 2022
@nirinchev nirinchev deleted the ni/api-keys branch October 21, 2022 10:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desistefanova desistefanova desistefanova left review comments

@blagoev blagoev blagoev approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes no-changelog Used to skip the changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nirinchev @coveralls @blagoev @desistefanova