Improved subscribe API #1356
Merged
Improved subscribe API #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
May 2, 2023 14:18
… and NetworkTransport
# Conflicts: # packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/internal/AppImpl.kt
cmelchior
requested review from
clementetb and
rorbech
and removed request for
clementetb
# Conflicts: # CHANGELOG.md # packages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/shared/SubscriptionExtensionsTests.kt
rorbech
reviewed
Jun 7, 2023
packages/library-base/src/commonMain/kotlin/io/realm/kotlin/internal/RealmResultsImpl.kt
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/ext/RealmQueryExt.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/ext/RealmQueryExt.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/ext/RealmQueryExt.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/ext/RealmQueryExt.kt
Show resolved
Hide resolved
...ync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/shared/SubscriptionExtensionsTests.kt
Outdated
Show resolved
Hide resolved
...ync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/shared/SubscriptionExtensionsTests.kt
Outdated
Show resolved
Hide resolved
...ync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/shared/SubscriptionExtensionsTests.kt
Outdated
Show resolved
Hide resolved
...ync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/shared/SubscriptionExtensionsTests.kt
Outdated
Show resolved
Hide resolved
...ync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/shared/SubscriptionExtensionsTests.kt
Outdated
Show resolved
Hide resolved
clementetb
reviewed
Jun 9, 2023
...ync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/shared/SubscriptionExtensionsTests.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/ext/RealmQueryExt.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/ext/RealmResultsExt.kt
Show resolved
Hide resolved
.../library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/internal/AppConfigurationImpl.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/Subscription.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/WaitForSync.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/WaitForSync.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/WaitForSync.kt
Outdated
Show resolved
Hide resolved
| @@ -320,15 +320,14 @@ class RealmTests { | |||
|
|
|||
| @Test | |||
| @Suppress("invisible_member") | |||
| fun writeAfterCloseThrows() = runBlocking { | |||
| fun writeAfterCloseThrows() = runBlocking<Unit> { | |||
There was a problem hiding this comment.
We might consider start using runTest, from kotlinx-coroutines-test.
...ync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/shared/MutableSubscriptionSetTests.kt
Outdated
Show resolved
Hide resolved
added 5 commits
June 14, 2023 08:05
# Conflicts: # packages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/SubscriptionExtensionsTests.kt
# Conflicts: # packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/internal/AppImpl.kt
|
@clementetb I should have addressed all concerns now, making this ready for round 2 🙏 |
clementetb
approved these changes
Jun 16, 2023
...ges/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/internal/RealmQueryExtImpl.kt
Outdated
Show resolved
Hide resolved
| @@ -30,6 +31,11 @@ import kotlin.reflect.KClass | |||
| */ | |||
| public interface Subscription { | |||
|
|
|||
| /** | |||
| * An unique id, generated by Realm, that identifies this subscription. | |||
There was a problem hiding this comment.
Suggested change
| * An unique id, generated by Realm, that identifies this subscription. | |
| * A unique id, generated by Realm, that identifies this subscription. |
...ync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/SubscriptionExtensionsTests.kt
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
subscribemethod making it easier to create subscriptions from queries and query results.Since the
subscribemethods have a high chance of being called from a UI context, they are switching to the dispatcher provided by theAppConfiguration. This required reworking the logic around the dispatcher, as previously it was only used by the KtorNetworkTransport.Now that it can be used by all Sync APIs that want to delegate things to the background. I didn't want to use the notifier dispatcher since we risked it getting blocked by people trying to update subscriptions.
Due to 2 bugs in Coroutines, I had to bump the minimum supported version to 1.7.0: Kotlin/kotlinx.coroutines#3768