[BUG] Allow dossier.yml to override database name #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it stands the DATABASE_URL will override anything in dossier.yml.
Some configurations need those values especially in the database name.
For example where the DATABASE_URL might look like this:
postgres://postgres@postgres:5432/
With a dossier.yml:
development:
database: my_database_dev
Would have caused Dossier to break complaining that **Database "/" does
not exist**
Further still with a DATABASE_URL that has the trailing slash removed
dossier will assume the database name is "" (empty string)
This is especially problematic when the database name changes based on
the RAILS_ENV.
|
The method is executed as part of the specs already in place. How could that one method equate to 38% of the code?! Something is very wrong with coveralls! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands the
DATABASE_URLwill override anything indossier.yml. Some configurations need those values especially in the database name.For example where the
DATABASE_URLmight look like this:With a
dossier.yml:Would have caused Dossier to break complaining that Database "/" does not exist
Further still with a
DATABASE_URLthat has the trailing slash removed dossier will assume the database name is""(empty string)This is especially problematic when the database name changes based on the
RAILS_ENV.