Skip to content
This repository has been archived by the owner on Nov 20, 2020. It is now read-only.

Make compatible with GraphQL PPX 1.0 beta #117

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

jfrolich
Copy link
Member

🚧🚧 Only if you want to try the unstable beta of GraphQL PPX 1.0 🚧🚧

GraphQL PPX adds quite a bit of breaking changes, this fork makes it compatible.

There are also some other changes, as this is the version we use in production

Mainly

  • Making compatible with apollo-client 3 (also making this independent of reason-apollo and inlining some code to make this work).
  • Execution result in an inline module to more easily pattern match (due to similar data types in same module)

@@ -0,0 +1,128 @@
open ReasonApolloTypes;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be amazing if this would be moved to another package so reason-apollo and reason-apollo-hooks could share the same ApolloClient definitions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to have a single package, because the hooks are now also part of the same @apollo/client package.

@baransu baransu mentioned this pull request Apr 29, 2020
26 tasks
};

[@bs.module "@apollo/client"]
external useSubscription:
(ReasonApolloTypes.queryString, options('raw_t)) =>
(ReasonApolloTypes.queryString, options('raw_t, 'raw_t_variables)) =>
{
.
"data": Js.Nullable.t(Js.Json.t),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be "data": Js.Nullable.t('raw_t),?

@jfrolich jfrolich marked this pull request as draft May 23, 2020 07:40
@jeddeloh jeddeloh mentioned this pull request Jun 7, 2020
@woeps
Copy link

woeps commented Jun 26, 2020

When I tried to use this branch I got confused because the readme still states to install and use reason-apollo. I'd try to find some time after the weekend to pr changes to the readme.

@woeps
Copy link

woeps commented Jul 2, 2020

@chrispad2k just started to work on the readme pr.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants