Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(deps): Unpin melange version and bump other dep versions #322

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trite
Copy link

@trite trite commented Jun 17, 2022

  • Ocaml updated to 4.14.0 (version used by melange currently)
  • Melange unpinned
  • Melange build command updated:
  • rm not needed thanks to -sfn flags on ln forcing symlink creation
  • symlink changed to use node_modules/melange instead of the previous bucklescript path (unit tests will fail without this)

@mlms13
Copy link
Member

mlms13 commented Jun 20, 2022

This all looks good to me. The only thing is, I think we probably want only the yarn.lock, not also the package-lock. Maybe we should add package-lock to the gitignore.

@trite
Copy link
Author

trite commented Jun 20, 2022

Added!

@mlms13
Copy link
Member

mlms13 commented Jun 20, 2022

Awesome, thanks! Would you mind also deleting the package-lock.json that slipped in there before it was gitignore'd?

@trite
Copy link
Author

trite commented Jun 20, 2022

Done, squashed it all into one commit for sanity's sake.

@mlms13 mlms13 mentioned this pull request Jun 22, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants