Use testbench WithConfig attribute to set app.debug
#1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the failing test `testNoExplicitContentType` We do set it in `\Rebing\GraphQL\Tests\TestCase::getEnvironmentSetUp` which _is_ executed in the this test, but too late. By the time `\Illuminate\Foundation\Providers\FoundationServiceProvider::registerExceptionRenderer` is called, the `getEnvironmentSetUp()` is not yet called and therefore the debug mode being enabled is not realized. But other parts in the framework later "see" the enabled debug mode, and due to this mismatch the framework expects registered classes which however arent.
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the failing test
testNoExplicitContentType(#1137)We do set it in
\Rebing\GraphQL\Tests\TestCase::getEnvironmentSetUpwhich is executed in the this test, but too late.By the time
\Illuminate\Foundation\Providers\FoundationServiceProvider::registerExceptionRendereris called, thegetEnvironmentSetUp()is not yet called and therefore the debug mode being enabled is not realized.But other parts in the framework later "see" the enabled debug mode, and due to this mismatch the framework expects registered classes which however arent.
Type of change:
Checklist:
composer fix-style