fix(archive): validate pro value when opening archive

internal/archive/archive.go

@@ -173,7 +173,7 @@ var proArchiveInfo = map[string]struct {
 }
 
 // archiveURL returns the archive base URL depending on the "pro" value and
-// selected architecture "arch". The "pro" value must be pre-validated.
+// selected architecture "arch".
 func archiveURL(pro, arch string) string {
 	if pro != "" {
 		return proArchiveInfo[pro].BaseURL
@@ -194,6 +194,11 @@ func openUbuntu(options *Options) (Archive, error) {
 	if len(options.Version) == 0 {
 		return nil, fmt.Errorf("archive options missing version")
 	}
+	if options.Pro != "" {
+		if _, ok := proArchiveInfo[options.Pro]; !ok {
+			return nil, fmt.Errorf("invalid pro value: %q", options.Pro)
+		}
+	}
 
 	baseURL := archiveURL(options.Pro, options.Arch)
 	var creds *credentials

internal/archive/archive_test.go

@@ -181,6 +181,16 @@ var optionErrorTests = []optionErrorTest{{
 		Components: []string{"main", "other"},
 	},
 	error: `invalid package architecture: foo`,
+}, {
+	options: archive.Options{
+		Label:      "ubuntu",
+		Version:    "22.04",
+		Arch:       "amd64",
+		Suites:     []string{"jammy"},
+		Components: []string{"main", "other"},
+		Pro:        "invalid",
+	},
+	error: `invalid pro value: "invalid"`,
 }}
 
 func (s *httpSuite) TestOptionErrors(c *C) {