Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passing empty string "" to query param results in 0 returned records #2400

Closed
davidberenstein1957 opened this issue Feb 23, 2023 · 0 comments · Fixed by #2429
Closed

passing empty string "" to query param results in 0 returned records #2400

davidberenstein1957 opened this issue Feb 23, 2023 · 0 comments · Fixed by #2429
Assignees
@frascuchon
Labels
type: bug Indicates an unexpected problem or unintended behavior
Milestone
v1.4.0

Comments

@davidberenstein1957
Copy link
Member

Describe the bug
passing empty string "" to query param results in 0 returned records

To Reproduce
Steps to reproduce the behaviour:
rg.load("datasets", query="")
returns
0 records

Expected behavior
I would expect it to return all records

Screenshots
N.A.

Environment (please complete the following information):

  • OS [e.g. iOS]: N.A.
  • Browser [e.g. chrome, safari]: N.A.
  • Argilla Version [e.g. 1.0.0]: 1.3.0
  • ElasticSearch Version [e.g. 7.10.2]: N.A.
  • Docker Image (optional) [e.g. argilla:v1.0.0]: N.A.

Additional context
N.A.
@davidberenstein1957 davidberenstein1957 added the type: bug Indicates an unexpected problem or unintended behavior label Feb 23, 2023
@davidberenstein1957 davidberenstein1957 mentioned this issue Feb 27, 2023
Merged
2 tasks
@davidberenstein1957 davidberenstein1957 linked a pull request Feb 27, 2023 that will close this issue
fix: error when loading record with empty string query #2429
Merged
2 tasks
@davidberenstein1957 davidberenstein1957 mentioned this issue Feb 27, 2023
Closed
@frascuchon frascuchon added this to the v1.4.0 milestone Mar 2, 2023
frascuchon pushed a commit that referenced this issue Mar 2, 2023
@davidberenstein1957
fix: error when loading record with empty string query (#2429)
fc71c3b 
# Description
empty query strings were not returning any records. These are currently
set to None and therefore return records again.

Closes #2400 
Closes #2303 
**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [X] Bug fix (non-breaking change which fixes an issue)

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

- [x] [Test
A](https://github.com/argilla-io/argilla/blob/34da84b5b0ac2c71d17459519915630dda7393a2/tests/client/test_api.py#L179)


**Checklist**

N.A.
@frascuchon frascuchon mentioned this issue Mar 8, 2023
Merged
frascuchon added a commit that referenced this issue Mar 9, 2023
@frascuchon
Release 1.4.0 (#2500)
cf75dd5 
# [1.4.0](v1.3.1...v1.4.0)
(2023-03-09)

### Features

* `configure_dataset` accepts a workspace as argument
([#2503](#2503))
([29c9ee3](29c9ee3)),
* Add `active_client` function to main argilla module
([#2387](#2387))
([4e623d4](4e623d4)),
closes [#2183](#2183)
* Add text2text support for prepare for training spark nlp
([#2466](#2466))
([21efb83](21efb83)),
closes [#2465](#2465)
[#2482](#2482)
* Allow passing workspace as client param for `rg.log` or `rg.load`
([#2425](#2425))
([b3b897a](b3b897a)),
closes [#2059](#2059)
* Bulk annotation improvement
([#2437](#2437))
([3fce915](3fce915)),
closes [#2264](#2264)
* Deprecate `chunk_size` in favor of `batch_size` for `rg.log`
([#2455](#2455))
([3ebea76](3ebea76)),
closes [#2453](#2453)
* Expose `batch_size` parameter for `rg.load`
([#2460](#2460))
([e25be3e](e25be3e)),
closes [#2454](#2454)
[#2434](#2434)
* Extend shortcuts to include alphabet for token classification
([#2339](#2339))
([4a92b35](4a92b35))


### Bug Fixes

* added flexible app redirect to docs page
([#2428](#2428))
([5600301](5600301)),
closes [#2377](#2377)
* added regex match to set workspace method
([#2427](#2427))
([d789fa1](d789fa1)),
closes [#2388]
* error when loading record with empty string query
([#2429](#2429))
([fc71c3b](fc71c3b)),
closes [#2400](#2400)
[#2303](#2303)
* Remove extra-action dropdown state after navigation
([#2479](#2479))
([9328994](9328994)),
closes [#2158](#2158)


### Documentation

* Add AutoTrain to readme
([7199780](7199780))
* Add migration to label schema section
([#2435](#2435))
([d57a1e5](d57a1e5)),
closes [#2003](#2003)
[#2003](#2003)
* Adds zero+few shot tutorial with SetFit
([#2409](#2409))
([6c679ad](6c679ad))
* Update readme with quickstart section and new links to guides
([#2333](#2333))
([91a77ad](91a77ad))


## As always, thanks to our amazing contributors!
- Documentation update: adding missing n (#2362) by @Gnonpi
- feat: Extend shortcuts to include alphabet for token classification
(#2339) by @cceyda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

fix: error when loading record with empty string query argilla-io/argilla
2 participants
@frascuchon @davidberenstein1957