Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset settings] New section in UI #2003

Closed
6 tasks done
frascuchon opened this issue Dec 5, 2022 · 3 comments · Fixed by #2442
Closed
6 tasks done

[Dataset settings] New section in UI #2003

frascuchon opened this issue Dec 5, 2022 · 3 comments · Fixed by #2442
Assignees
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests type: technical debt Indicates that technical debt needs to be solved
Milestone

Comments

@frascuchon
Copy link
Member

frascuchon commented Dec 5, 2022

We need to change the front-end part to create new labels by using the labeling schema already defined as part of the dataset settings.

Including these changes, we need to think about how to restrict the use of label creation to users.

cc @dvsrepo

Updated

This view cannot be visible for ALL users. For example, for now, the "Create label" button is only shown when no settings resource is found (from an API call), or deleting a dataset is only possible for dataset creators.

The condition will be (until argilla has no user role assignment):

Show dataset settings view only for users that have created the dataset (cc @dvsrepo)

Also, we should unify the current labels schema to the settings resource (cc @keithCuniah @leiyre )

Tasks

@frascuchon frascuchon added type: enhancement Indicates new feature requests type: technical debt Indicates that technical debt needs to be solved labels Dec 5, 2022
@Amelie-V Amelie-V added the area: ui Indicates that an issue or pull request is related to the User Interface (UI) label Jan 23, 2023
@Amelie-V Amelie-V added this to the v1.4.0 milestone Feb 13, 2023
@Amelie-V Amelie-V changed the title Using dataset settings to manage dataset label creation [Dataset settings] New section in UI Feb 13, 2023
@Amelie-V
Copy link
Member

We will create a proper area for dataset settings. The two main sets accessible to users from the UI are:

  • Label creation
  • Delete dataset

These two features already exist on the UI.

It consists of relocating them into a dedicated page.

@Amelie-V Amelie-V self-assigned this Feb 13, 2023
@frascuchon
Copy link
Member Author

Refs #1854

@frascuchon
Copy link
Member Author

leiyre added a commit that referenced this issue Mar 1, 2023
# Description

This PR includes an icon in the dataset list to go to dataset settings

See [#2003](#2003)

**Type of change**

- [x] New feature (non-breaking change which adds functionality)

**Checklist**

- [x] I have merged the original branch into my forked branch
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [x] My changes generate no new warnings
frascuchon added a commit that referenced this issue Mar 6, 2023
# Description

Adding the missing section to migrate labels created directly from UI to
a proper label schema.

Once #2003 is released, this migration will be a requirement, so, this
section must be referenced in v1.4.0 release.

Refs: #2003

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)
- [x] Documentation update


**Checklist**

- [x] I have merged the original branch into my forked branch
- [x] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [x] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works

---------

Co-authored-by: David Berenstein <[email protected]>
@frascuchon frascuchon modified the milestones: v1.4.0, v1.5.0 Mar 8, 2023
frascuchon added a commit that referenced this issue Mar 9, 2023
# [1.4.0](v1.3.1...v1.4.0)
(2023-03-09)

### Features

* `configure_dataset` accepts a workspace as argument
([#2503](#2503))
([29c9ee3](29c9ee3)),
* Add `active_client` function to main argilla module
([#2387](#2387))
([4e623d4](4e623d4)),
closes [#2183](#2183)
* Add text2text support for prepare for training spark nlp
([#2466](#2466))
([21efb83](21efb83)),
closes [#2465](#2465)
[#2482](#2482)
* Allow passing workspace as client param for `rg.log` or `rg.load`
([#2425](#2425))
([b3b897a](b3b897a)),
closes [#2059](#2059)
* Bulk annotation improvement
([#2437](#2437))
([3fce915](3fce915)),
closes [#2264](#2264)
* Deprecate `chunk_size` in favor of `batch_size` for `rg.log`
([#2455](#2455))
([3ebea76](3ebea76)),
closes [#2453](#2453)
* Expose `batch_size` parameter for `rg.load`
([#2460](#2460))
([e25be3e](e25be3e)),
closes [#2454](#2454)
[#2434](#2434)
* Extend shortcuts to include alphabet for token classification
([#2339](#2339))
([4a92b35](4a92b35))


### Bug Fixes

* added flexible app redirect to docs page
([#2428](#2428))
([5600301](5600301)),
closes [#2377](#2377)
* added regex match to set workspace method
([#2427](#2427))
([d789fa1](d789fa1)),
closes [#2388]
* error when loading record with empty string query
([#2429](#2429))
([fc71c3b](fc71c3b)),
closes [#2400](#2400)
[#2303](#2303)
* Remove extra-action dropdown state after navigation
([#2479](#2479))
([9328994](9328994)),
closes [#2158](#2158)


### Documentation

* Add AutoTrain to readme
([7199780](7199780))
* Add migration to label schema section
([#2435](#2435))
([d57a1e5](d57a1e5)),
closes [#2003](#2003)
[#2003](#2003)
* Adds zero+few shot tutorial with SetFit
([#2409](#2409))
([6c679ad](6c679ad))
* Update readme with quickstart section and new links to guides
([#2333](#2333))
([91a77ad](91a77ad))


## As always, thanks to our amazing contributors!
- Documentation update: adding missing n (#2362) by @Gnonpi
- feat: Extend shortcuts to include alphabet for token classification
(#2339) by @cceyda
frascuchon added a commit that referenced this issue Mar 22, 2023
## [1.5.0](v1.4.0...v1.5.0) -
2023-03-21

### Added

- Add the fields to retrieve when loading the data from argilla.
`rg.load` takes too long because of the vector field, even when users
don't need it. Closes
[#2398](#2398)
- Add new page and components for dataset settings. Closes
[#2442](#2003)
- Add ability to show image in records (for TokenClassification and
TextClassification) if an URL is passed in metadata with the key
\_image_url
- Non-searchable fields support in metadata.
[#2570](#2570)

### Changed

- Labels are now centralized in a specific vuex ORM called GlobalLabel
Model, see #2210. This model
is the same for TokenClassification and TextClassification (so both task
have labels with color_id and shortcuts parameters in the vuex ORM)
- The shortcuts improvement for labels
[#2339](#2339) have been moved
to the vuex ORM in dataset settings feature
[#2444](eb37c3b)
- Update "Define a labeling schema" section in docs.
- The record inputs are sorted alphabetically in UI by default.
[#2581](#2581)

### Fixes

- Allow URL to be clickable in Jupyter notebook again. Closes
[#2527](#2527)

### Removed

- Removing some data scan deprecated endpoints used by old clients. This
change will break compatibility with client `<v1.3.0`
- Stop using old scan deprecated endpoints in python client. This logic
will break client compatibility with server version `<1.3.0`
- Remove the previous way to add labels through the dataset page. Now
labels can be added only through dataset settings page.



### As always, thanks to our amazing contributors!
- Documentation update: tutorial for text classification models
comparison (#2426) by @embonhomme
- Docs: fix little typo (#2522) by @anakin87
- Docs: Tutorial on image classification (#2420) by @burtenshaw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests type: technical debt Indicates that technical debt needs to be solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants