-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pyspark test #1909
Merged
miguelgfierro
merged 13 commits into
miguel/error_spark_benchmark
from
jumin/fix_pyspark_test
Mar 30, 2023
Merged
Fix pyspark test #1909
miguelgfierro
merged 13 commits into
miguel/error_spark_benchmark
from
jumin/fix_pyspark_test
Mar 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loomlike
requested review from
miguelgfierro,
gramhagen,
anargyri,
wutaomsft and
simonzhaoms
as code owners
March 30, 2023 00:45
@miguelgfierro This PR is merging into your branch. You'll need to revert the commented tests back from your branch before merging into Staging or Main. |
miguelgfierro
approved these changes
Mar 30, 2023
Comment on lines
+83
to
+87
|
||
os.environ["PYSPARK_PYTHON"] = sys.executable | ||
os.environ["PYSPARK_DRIVER_PYTHON"] = sys.executable | ||
os.environ.pop("SPARK_HOME", None) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, actually I haven't thought of this option.
Spark is like a kid that is going through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Env vars necessary to use PySpark doesn't set properly when using AzureML for testing.
This PR sets the env vars. Additionally, increase the stack size in driver and executors to avoid StackOverflowError.
Related Issues
#1898
Checklist: