Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daviddavo/less concats #2074

Closed
wants to merge 88 commits into from
Closed

Daviddavo/less concats #2074

wants to merge 88 commits into from

Conversation

daviddavo
Copy link
Collaborator

Description

Just replaced with a oneliner to make just one concat instead of two

Related Issues

References

[...] If function is None, the identity function is assumed, that is, all elements of iterable that are false are removed.

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

simonzhaoms and others added 30 commits June 6, 2023 19:49
@simonzhaoms
Add support for Python 3.10 and 3.11
ffac856
@simonzhaoms
Correct upper bound version for category_encoders
ffd8b9e
@simonzhaoms
Add tests for Python 3.10 and 3.11
644aa5d
@simonzhaoms
Remove dependencies that others require
9003450
@simonzhaoms
Merge in staging
a157403
@simonzhaoms
Update nvidia-ml-py and tensorflow version
793ec87
@simonzhaoms
Install system level dependencies for scipy
1556eb4
@simonzhaoms
Merge in staging
34aee1d
@simonzhaoms
Support from Python 3.8 to 3.11
890a3fe
@simonzhaoms
Remove unused system deps
c7bb846
@simonzhaoms
Drop python 3.11 because some packages do not support 3.11
7f2e298
@simonzhaoms
Install dependencies for scipy in docker image
09069f7
@simonzhaoms
Change docker image
643fed6
@simonzhaoms
Add pip==20.1.1
db4c9c3
@simonzhaoms
Correct conda package format
9e05e4f
@simonzhaoms
Remove pip downgrade code
e1d6acf
@simonzhaoms
Use docker images for ubuntu 22.04
b71c4ed
@SimonYansenZhao
Merge in main
3b4a641
@SimonYansenZhao
Merge in staging
3cb052a
@SimonYansenZhao
Replace pandas.util.testing with pandas.testing
d80002e
@SimonYansenZhao
Remove nonexistent argument check_less_precise of assert_frame_equal()
e084412
@SimonYansenZhao
Remove tests for sarplus for Python 3.7
a605404
@SimonYansenZhao
Fixed error: 'DataFrame' object has no attribute 'append'
40361f4
@SimonYansenZhao
Add hypothesis<6.83.1
9364c9b
@SimonYansenZhao @miguelgfierro
Use ubuntu-22.04 instead of latest
be86a29 
Co-authored-by: Miguel Fierro <[email protected]>
@SimonYansenZhao
Update comments
0641d95
@SimonYansenZhao
Merge remote-tracking branch 'origin/simonz-dep-upgrade-20230606' int…
334ea1a 
…o simonz-dep-upgrade-20230606
@SimonYansenZhao @miguelgfierro
Add python 3.11
60e847a 
Co-authored-by: Miguel Fierro <[email protected]>
@SimonYansenZhao @miguelgfierro
Add python 3.11
313de47 
Co-authored-by: Miguel Fierro <[email protected]>
@SimonYansenZhao @miguelgfierro
Add python 3.11
91be6ae 
Co-authored-by: Miguel Fierro <[email protected]>
SimonYansenZhao and others added 23 commits February 24, 2024 13:41
@SimonYansenZhao
Allow Python 3.11 for sarplus
ed3b632
@miguelgfierro
Rerun and fix fastai movielens notebook
c8d90f7 
Signed-off-by: miguelgfierro <[email protected]>
@miguelgfierro
Fixed deprecated attribute in fastai
d9ec1cd 
Signed-off-by: miguelgfierro <[email protected]>
@SimonYansenZhao
Merge pull request #2068 from recommenders-team/miguel/simon_deps
d59f7ec 
Fixed error in fastai in nightly
@miguelgfierro
Fixing breaking changes in fastai
fda5265 
Signed-off-by: miguelgfierro <[email protected]>
@SimonYansenZhao
Upgrade GitHub Action azure/login
ac90e54
@SimonYansenZhao
Update fastai usage in utils
1d0fe7d
@loomlike
change deprecated azureml option (#2069)
0740b16 
Signed-off-by: Jun Ki Min <[email protected]>
@loomlike
Update SP creation doc
89cc985 
Signed-off-by: Jun Ki Min <[email protected]>
@miguelgfierro
📝
55433c5 
Signed-off-by: miguelgfierro <[email protected]>
@miguelgfierro
Fixing TF to < 2.16
730a5e9
@miguelgfierro
🐛
657531a 
Signed-off-by: miguelgfierro <[email protected]>
@miguelgfierro
model to CUDA as well as data
e99b8d0 
Signed-off-by: miguelgfierro <[email protected]>
@SimonYansenZhao
Set tensorflow <= 2.15.0
03554de 
Signed-off-by: Simon Zhao <[email protected]>
@SimonYansenZhao
Add missing colon
47281c8 
Signed-off-by: Simon Zhao <[email protected]>
@miguelgfierro
Merge branch 'simonz-dep-upgrade-20230606' into miguel/fix_tf
19bcf1a
@miguelgfierro
📝
b255fae 
Signed-off-by: miguelgfierro <[email protected]>
@miguelgfierro
Reducing DKN batch size to 200
85899cf 
Signed-off-by: miguelgfierro <[email protected]>
@SimonYansenZhao
Move learner.model to cuda if cuda is available
d8e8ac3 
Signed-off-by: Simon Zhao <[email protected]>
@miguelgfierro
Merge branch 'simonz-dep-upgrade-20230606' into miguel/fix_tf
21492c9
@miguelgfierro
Merge pull request #2071 from recommenders-team/miguel/fix_tf
14c5c93 
Fixing TF to < 2.16
@miguelgfierro
Merge pull request #1937 from recommenders-team/simonz-dep-upgrade-20…
3821655 
…230606

Add support for Python 3.10 and 3.11
@daviddavo
Merged two concats into one
e049564 
Signed-off-by: David Davó <[email protected]>
@daviddavo daviddavo closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro Awaiting requested review from miguelgfierro miguelgfierro is a code owner

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@SimonYansenZhao SimonYansenZhao Awaiting requested review from SimonYansenZhao SimonYansenZhao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@daviddavo @simonzhaoms @SimonYansenZhao @gazon1 @anargyri @miguelgfierro @loomlike