Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schema for data extension property proposal responses #119

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Add schema for data extension property proposal responses #119

merged 2 commits into from
Mar 27, 2023

Conversation

wetneb
Copy link
Member

@wetneb wetneb commented Mar 25, 2023

Closes #118.
(To be duplicated in /0.2 - not included in this PR to keep it concise)

@wetneb wetneb requested a review from fsteeg March 25, 2023 13:45
fsteeg
fsteeg approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested one minor typo fix inline.

Also noticed some descriptions end with ., others don't, but that's true for the other schemas too.

draft/schemas/data-extension-property-proposal.json Outdated Show resolved Hide resolved
@wetneb @fsteeg
Fix typo
e9822fa 
Co-authored-by: Fabian Steeg <[email protected]>
@wetneb wetneb mentioned this pull request Mar 27, 2023
Open
@wetneb
Copy link
Member Author

wetneb commented Mar 27, 2023

Thanks, good catch! Opening another issue to normalize descriptions: #120

@wetneb wetneb merged commit 8e8232c into master Mar 27, 2023
fsteeg added a commit that referenced this pull request Jul 13, 2023
@wetneb @fsteeg
Add schema for data extension property proposal responses (#119)
ab97ba9 
* Add schema for data extension property proposal responses. Closes #118.

* Fix typo

Co-authored-by: Fabian Steeg <[email protected]>

---------

Co-authored-by: Fabian Steeg <[email protected]>
@wetneb wetneb deleted the 118-json-schema-property-proposal branch April 6, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsteeg fsteeg fsteeg approved these changes

Assignees

@wetneb wetneb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No JSON schema for data extension property proposal response
2 participants
@wetneb @fsteeg