add some missing non-square matrix funcs #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@recp Do you need any help with this MR. I can write some docs for you. |
|
@EasyIP2023 thanks, it would be nice to have docs and tests yes ;) |
|
@recp Question is |
|
@recp Nevermind just thought about why |
Functions include: * glm_mat#x#_copy * glm_mat#x#_zero * glm_mat#x#_mul * glm_mat#x#_mulv * glm_mat#x#_transpose * glm_mat#x#_scale Commit also includes some minor changes to * mat2 * mat3 * mat4 Signed-off-by: Vincent Davis Jr <[email protected]>
warning: array subscript # is outside array bounds of ‘float[#]’ [-Warray-bounds] Commit also fixes variable order when calculating multiplication between two matrices. Signed-off-by: Vincent Davis Jr <[email protected]>
Signed-off-by: Vincent Davis Jr <[email protected]>
Signed-off-by: Vincent Davis Jr <[email protected]>
Signed-off-by: Vincent Davis Jr <[email protected]>
Signed-off-by: Vincent Davis Jr <[email protected]>
Signed-off-by: Vincent Davis Jr <[email protected]>
Signed-off-by: Vincent Davis Jr <[email protected]>
add docs and tests to non-square-matrix branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add missing functions for new non-square matrices: