Skip to content

Commit

Permalink
[Performance] Remove unnecessary usage of SimpleCallableNodeTraverser…
Browse files Browse the repository at this point in the history
… on UseImportsTraverser (#6288)
  • Loading branch information
samsonasik authored Sep 5, 2024
1 parent 1c20d81 commit 246de2d
Showing 1 changed file with 15 additions and 17 deletions.
32 changes: 15 additions & 17 deletions rules/CodingStyle/ClassNameImport/UseImportsTraverser.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,17 @@

namespace Rector\CodingStyle\ClassNameImport;

use PhpParser\Node;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\GroupUse;
use PhpParser\Node\Stmt\Namespace_;
use PhpParser\Node\Stmt\Use_;
use PhpParser\Node\Stmt\UseUse;
use PhpParser\NodeTraverser;
use Rector\NodeNameResolver\NodeNameResolver;
use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
use Rector\PhpParser\Node\CustomNode\FileWithoutNamespace;

final readonly class UseImportsTraverser
{
public function __construct(
private SimpleCallableNodeTraverser $simpleCallableNodeTraverser,
private NodeNameResolver $nodeNameResolver
) {
}
Expand All @@ -29,29 +25,31 @@ public function __construct(
*/
public function traverserStmts(array $stmts, callable $callable): void
{
$this->simpleCallableNodeTraverser->traverseNodesWithCallable($stmts, function (Node $node) use (
$callable,
): ?int {
if ($node instanceof Namespace_ || $node instanceof FileWithoutNamespace) {
// traverse into namespaces
return null;
foreach ($stmts as $stmt) {
if ($stmt instanceof Namespace_ || $stmt instanceof FileWithoutNamespace) {
$this->traverserStmts($stmt->stmts, $callable);
return;
}

if ($node instanceof Use_) {
foreach ($node->uses as $useUse) {
if (! $stmt instanceof Use_ && ! $stmt instanceof GroupUse) {
continue;
}

if ($stmt instanceof Use_) {
foreach ($stmt->uses as $useUse) {
$name = $this->nodeNameResolver->getName($useUse);
if ($name === null) {
continue;
}

$callable($node->type, $useUse, $name);
$callable($stmt->type, $useUse, $name);
}
} elseif ($node instanceof GroupUse) {
$this->processGroupUse($node, $callable);

continue;
}

return NodeTraverser::DONT_TRAVERSE_CURRENT_AND_CHILDREN;
});
$this->processGroupUse($stmt, $callable);
}
}

/**
Expand Down

0 comments on commit 246de2d

Please sign in to comment.