Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Scoper] Skip Prefix\Composer\ usage" #6294

Merged
merged 1 commit into from
May 2, 2021

Conversation

samsonasik
Copy link
Member

Reverts #6293 change all $prefix\Composer\ to Composer cause error on php 7.1 scoped. Reverting it.

@samsonasik samsonasik enabled auto-merge (squash) May 2, 2021 17:38
@samsonasik samsonasik merged commit 1070505 into main May 2, 2021
@samsonasik samsonasik deleted the revert-6293-scoper-skip-composer-backslash branch May 2, 2021 17:45
@TomasVotruba
Copy link
Member

TomasVotruba commented May 2, 2021

Please use separated scoper.php file for PHP 7.0, so it won't break the build PHP 7.1 like last week

@TomasVotruba
Copy link
Member

TomasVotruba commented May 2, 2021

See https://github.com/rectorphp/rector-prefixed, now if fails :(

@samsonasik
Copy link
Member Author

yes, it is strange:

  git add --all
  git commit -m "Updated Rector to commit 10705059a3a0e6b791d175daba90d37cd365ab0e" -m "https://github.com/rectorphp/rector/commit/10705059a3a0e6b791d175daba90d37cd365ab0e Revert "[Scoper] Skip Prefix\Composer\ usage (#6293)" (#6294)"
  git push --quiet origin main
  shell: /usr/bin/bash -e {0}
  env:
    COMPOSER_ROOT_VERSION: dev-main

/home/runner/work/_temp/04d218f8-1262-472a-9f8c-7399302355c7.sh: line 2: syntax error near unexpected token `('
Error: Process completed with exit code 2.

which work on previous commit that is reverted deprecated-packages/rector-prefixed@e144121

TomasVotruba added a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants