ability to disable certificate check #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theromis can you please take care about the conflicts? |
|
@loeffel-io done, please check |
loeffel-io
requested changes
Aug 2, 2019
|
@loeffel-io I don't think I'm exporting something in this commit. Could you clarify your request? I have a chat app, and sometimes dns is not resolvable, so connecting over HTTPS fails in case of IP connection. This is why disabling ssl cert is critical for me. |
|
@theromis your |
|
@loeffel-io do you want me to close PR? |
loeffel-io
reviewed
Nov 28, 2019
loeffel-io
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.