Update the runtime image with the commit: 8bda2fa on main

[atheo89]

Update the runtime image with the commit: 8bda2fa on main

[openshift-ci]

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	5e7c9fd	link	true	/test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jstourac]

modh is probably another new organisation in quay.io for me. Do we have it documented somewhere which quay orgs serves to what? 🙃

Also, links to opendatahub/workbench-images:runtime* in these Dockerfiles are okay? Namely the values of io.openshift.build.image, io.openshift.build.source-location and authoritative-source-url

• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/datascience/ubi8-python-3.8/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/datascience/ubi9-python-3.9/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/minimal/ubi8-python-3.8/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/minimal/ubi9-python-3.9/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/pytorch/ubi8-python-3.8/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/pytorch/ubi9-python-3.9/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/tensorflow/ubi8-python-3.8/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/tensorflow/ubi9-python-3.9/Dockerfile

Regarding the Tensorflow - I don't like that the naming here doesn't match convention with the others - the runtime keyword isn't first. Is it possible to change this paradigm?

Doesn't need to be addressed in this PR, we can create an issue for that to track it if we agree.

[jstourac]

This Anaconda image points to the minimal one - is this on purpose?

[harshad16]

yes this is intentional
these are runtime image, directly doesn't have conda in them
they would be used by elyra pipeline, if someone executes them.

[harshad16]

modh is probably another new organisation in quay.io for me. Do we have it documented somewhere which quay orgs serves to what? 🙃

Also, links to opendatahub/workbench-images:runtime* in these Dockerfiles are okay? Namely the values of io.openshift.build.image, io.openshift.build.source-location and authoritative-source-url

• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/datascience/ubi8-python-3.8/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/datascience/ubi9-python-3.9/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/minimal/ubi8-python-3.8/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/minimal/ubi9-python-3.9/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/pytorch/ubi8-python-3.8/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/pytorch/ubi9-python-3.9/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/tensorflow/ubi8-python-3.8/Dockerfile
• https://github.com/red-hat-data-services/notebooks/blob/main/runtimes/tensorflow/ubi9-python-3.9/Dockerfile

Regarding the Tensorflow - I don't like that the naming here doesn't match convention with the others - the runtime keyword isn't first. Is it possible to change this paradigm?

Doesn't need to be addressed in this PR, we can create an issue for that to track it if we agree.

Documenting about the images, yes we need to do it
lets improve on that.

about the Dockerfiles labels. we should improve those as well.
will include it as a task.

Naming convention, i wouldn't change it anymore, as it is only on dev side, and users would see display name.

[jstourac]

Documenting about the images, yes we need to do it lets improve on that.

opendatahub-io#285

about the Dockerfiles labels. we should improve those as well. will include it as a task.

well, I was about to create an issue for that but I'm not sure whether we shall create it in upstream 🤔
update: created as opendatahub-io#292

Naming convention, i wouldn't change it anymore, as it is only on dev side, and users would see display name.

okay 🙃

[harshad16]

/lgtm
/approve
thanks 👍

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [harshad16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment