fix: use downloaded operator-sdk #230
Conversation
This commit updates the Makefile to use the downloaded operator-sdk so as to use a fixed version on every system. It also updates the operator-sdk version. Signed-off-by: N Balachandran <[email protected]>
openshift-ci
bot
added
the
approved
| @@ -268,20 +270,12 @@ endif | |||
|
|
|||
| .PHONY: operator-sdk | |||
| OPERATOR_SDK = ./bin/operator-sdk | |||
| operator-sdk: ## Download operator-sdk locally if necessary. | |||
| ifeq (,$(wildcard $(OPERATOR_SDK))) | |||
There was a problem hiding this comment.
- better have this one atleast or-else sdk is downloaded everytime the target is called
- the downside will be a mismatch version, however that's better than downloading everytime I believe.
There was a problem hiding this comment.
The intention is to use the same version everytime as we are seeing different behaviour with different versions.
There was a problem hiding this comment.
yes, if the frequency of calling this target as a sub-target is less I'd also vote for this PR.
| @@ -5,6 +5,8 @@ | |||
| # - use environment variables to overwrite this value (e.g export VERSION=0.0.2) | |||
| VERSION ?= 0.0.1 | |||
|
|
|||
| OPERATOR_SDK_VERSION ?= 1.21.0 | |||
There was a problem hiding this comment.
why not the latest version 1.22.2?
There was a problem hiding this comment.
There are breaking changes which I would like ti understand before upgrading to this version.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nbalacha, sp98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit updates the Makefile to use the downloaded
operator-sdk so as to use a fixed version on every system.
It also updates the operator-sdk version.
Signed-off-by: N Balachandran [email protected]