Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2168035:[release-4.11] bundle: remove debug logging from the manager auth proxy patch #293

Merged

Conversation

iamniting
Copy link
Member

@iamniting iamniting commented Feb 15, 2023

Having v=10 dumps sensitive information like tokens, resulting in information leakage if these logs are obtained. The Kubebuilder team also made this fix. They are also using v=0 now.

Ref: kubernetes-sigs/kubebuilder#2435

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2136852

Backport of #271

Having v=10 dumps sensitive information like tokens, resulting in
information leakage if these logs are obtained. The Kubebuilder
team also made this fix. They are also using v=0 now.

Ref: kubernetes-sigs/kubebuilder#2435

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2136852

Signed-off-by: Nitin Goyal <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2023

@iamniting: This pull request references Bugzilla bug 2168035, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.11.6) matches configured target release for branch (ODF 4.11.6)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2168035:[release-4.11] bundle: remove debug logging from the manager auth proxy patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@openshift-ci-robot
Copy link

@iamniting: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

Having v=10 dumps sensitive information like tokens, resulting in information leakage if these logs are obtained. The Kubebuilder team also made this fix. They are also using v=0 now.

Ref: kubernetes-sigs/kubebuilder#2435

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2136852

Backport of #271

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2023

@iamniting: This pull request references Bugzilla bug 2168035, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.11.6) matches configured target release for branch (ODF 4.11.6)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2168035:[release-4.11] bundle: remove debug logging from the manager auth proxy patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@malayparida2000 malayparida2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 74ae10a into red-hat-storage:release-4.11 Feb 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2023

@iamniting: All pull requests linked via external trackers have merged:

Bugzilla bug 2168035 has been moved to the MODIFIED state.

In response to this:

Bug 2168035:[release-4.11] bundle: remove debug logging from the manager auth proxy patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting iamniting deleted the release-4.11 branch April 25, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low bugzilla/valid-bug jira/valid-bug lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants