Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-enable Docker buildkit #515

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ANogin
Copy link
Contributor

@ANogin ANogin commented Nov 13, 2024

One sentence summary of this PR (This should go in the CHANGELOG!)
Default to forcing Docker buildkit to be enabled.

Link to Related Issue(s)
N/A; supersedes #392

Please describe the changes in your request.
Per @EdwardLarson:

Some features in the build require Docker buildkit to be enabled, and we say as much in the docs to build the image. However, this is a point of failure (for some reason I could not get the buildkit to be enabled in my machine) and a "gotcha" that can be removed entirely by just setting the Docker buildkit enabled in the subprocess we spin up to do the Docker build. In case there is a desire to specifically NOT use the buildkit, an option is added to not alter the subprocess environment at all (buildkit may or may not be enabled depending on user's environment).

Anyone you think should look at this, specifically?
@whyitfor

build_image.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants