Skip to content

Commit

Permalink
scsi: storvsc: properly handle SRB_ERROR when sense message is present
Browse files Browse the repository at this point in the history
When sense message is present on error, we should pass along to the upper
layer to decide how to deal with the error.
This patch fixes connectivity issues with Fiber Channel devices.

Signed-off-by: Long Li <[email protected]>
Reviewed-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: K. Y. Srinivasan <[email protected]>
Cc: <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
  • Loading branch information
longlimsft authored and martinkpetersen committed Jan 5, 2017
1 parent 3cd6d3d commit bba5dc3
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions drivers/scsi/storvsc_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -924,6 +924,13 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb,

switch (SRB_STATUS(vm_srb->srb_status)) {
case SRB_STATUS_ERROR:
/*
* Let upper layer deal with error when
* sense message is present.
*/

if (vm_srb->srb_status & SRB_STATUS_AUTOSENSE_VALID)
break;
/*
* If there is an error; offline the device since all
* error recovery strategies would have already been
Expand Down

0 comments on commit bba5dc3

Please sign in to comment.