httpbp: force http servers to define the methods their endpoints support #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ually create an http server
pacejackson
commented
Jun 8, 2020
| // Use the http.Method* constants from "net/http" for the values in this slice | ||
| // to ensure that you are using methods that are supported and in the format | ||
| // we expect. | ||
| Methods []string |
There was a problem hiding this comment.
🔕 Would it be better to have this be 2 values? Method string which is required and AdditionalMethods []string which is an optional list of additional HTTP methods that your endpoint supports? I feel like most cases just want to support a single method so this might be a better option on average?
pacejackson
commented
Jun 8, 2020
| wrappers := make([]Middleware, 0, len(f.middlewares)+len(middlewares)) | ||
| func (f httpHandlerFactory) NewHandler(endpoint Endpoint) http.Handler { | ||
| wrappers := make([]Middleware, 0, len(f.middlewares)+len(endpoint.Middlewares)+1) | ||
| wrappers = append(wrappers, SupportedMethods(endpoint.Methods[0], endpoint.Methods[1:]...)) |
There was a problem hiding this comment.
note, this will panic if you pass in an empty slice... let it! We already check this earlier by calling endpoint.Validate
fishy
approved these changes
Jun 8, 2020
| wrappers := make([]Middleware, 0, len(f.middlewares)+len(middlewares)) | ||
| func (f httpHandlerFactory) NewHandler(endpoint Endpoint) http.Handler { | ||
| wrappers := make([]Middleware, 0, len(f.middlewares)+len(endpoint.Middlewares)+1) | ||
| wrappers = append(wrappers, SupportedMethods(endpoint.Methods[0], endpoint.Methods[1:]...)) |
There was a problem hiding this comment.
🔕 til this won't cause panic when the slice contains one item: https://play.golang.org/p/HtkVu8laHF_n
konradreiche
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.