metricsbp: Switch back to use tags for sys stats #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacejackson
approved these changes
Jun 17, 2020
When we do aggregation for runtime.*.*.something gauges, we actually convert the hostname and pid part into tags before doing the real aggregation. We were doing that because we don't have tags in Baseplate.py. Since we already have tags in Baseplate.go, we really should just skip that step.
fishy
force-pushed
the
metrics-sys-stats-tags
branch
from
19c9840
to
a34ae79
Compare
pacejackson
approved these changes
Jun 17, 2020
konradreiche
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we do aggregation for runtime...something gauges, we actually
convert the hostname and pid part into tags before doing the real
aggregation. We were doing that because we don't have tags in
Baseplate.py.
Since we already have tags in Baseplate.go, we really should just skip
that step.