Commits on Sep 23, 2021

1. httpbp: Fix CircuitBreaker …

   Fix one bug: when status code >= 500 and closing the body does not error
   (it won't error in majority of cases), we do not actually report error
   to the circuit breaker.
   
   Also fix a few inefficiencies:
   
   1. When loaded is true, newBreaker is not used, so we can return it back
      to the pool immediately, instead of defer'd.
   2. Use DrainAndClose instead of ReadAll and Close, as
      io.Copy(io.Discard) is more efficient than ReadAll.
   3. Use pointer for the breaker in the pool and the map.
   
   Also avoid dealing with interface{} from breaker.Execute, and add a test
   to CircuitBreaker.

   

   fishy committed Sep 23, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 5aaf3df
   • Browse repository at this point

   Copy the full SHA

   5aaf3df View commit details

   Browse the repository at this point in the history