chore: Remove deprecated 'slug' label #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanassito
requested review from
fishy,
kylelemons and
pacejackson
and removed request for
a team
nanassito
force-pushed
the
clean-slug
branch
2 times, most recently
from
961b1bd
to
ed4eb62
Compare
pacejackson
approved these changes
Sep 19, 2022
nanassito
force-pushed
the
clean-slug
branch
from
ed4eb62
to
fc55888
Compare
nanassito
force-pushed
the
clean-slug
branch
from
fc55888
to
119eedf
Compare
fishy
approved these changes
Sep 19, 2022
kylelemons
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
As promised, I am removing the old, deprecated,
server_sluglabel in the prometheus metrics. It has been replaced byclient_namein a previous version.🧪 Testing Steps / Validation
uni tests
✅ Checks