thriftbp: Match thrift client pool metrics to baseplate spec #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily emit both new and old metrics, we will remove the old metrics after the next release (so the next release will have both). While I'm here, also: 1. Remove statsd metrics from thrift client pool 2. Change redis client pool metric name following spec change
fishy
requested review from
pacejackson and
mterwill
and removed request for
a team
fishy
commented
Oct 28, 2022
| defer func() { | ||
| clientPoolGetsCounter.With(prometheus.Labels{ | ||
| "thrift_pool": p.slug, | ||
| "thrift_success": strconv.FormatBool(err == nil), |
There was a problem hiding this comment.
note: the spec only defined thrift_pool label, but I think thrift_success label here would be really useful.
There was a problem hiding this comment.
What does "success" mean here though, succesfully getting a client from the pool?
There was a problem hiding this comment.
Yes. do you have a better name to suggest?
kylelemons
approved these changes
Oct 28, 2022
pacejackson
approved these changes
Oct 28, 2022
Comment on lines
+297
to
+298
| e.slug, | ||
| e.slug, |
There was a problem hiding this comment.
🔕 why is e.slug here twice? same below.
There was a problem hiding this comment.
we are emitting both the old thrift_client_name and new thrift_pool labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily emit both new and old metrics, we will remove the old metrics after the next release (so the next release will have both).
While I'm here, also: